TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

Include of autogenerating files are not idempotent #153

Open websi opened 1 month ago

websi commented 1 month ago

The path to file typo3/autoload-include.php is an absolute path. Composer use an hash to the file for the include. So the hash changes for different paths. This is very common in the CI system. This prevents effective caching of the generated files.

Similar use cases from composer: https://github.com/composer/composer/issues/7049 and https://github.com/composer/composer/issues/11226

Diff Image:

image

Patch:

Index: src/Plugin/Core/IncludeFile.php
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/src/Plugin/Core/IncludeFile.php b/src/Plugin/Core/IncludeFile.php
--- a/src/Plugin/Core/IncludeFile.php
+++ b/src/Plugin/Core/IncludeFile.php   (date 1664548565000)
@@ -70,7 +70,7 @@
         // Register the file in the root package
         $rootPackage = $this->composer->getPackage();
         $autoloadDefinition = $rootPackage->getAutoload();
-        $autoloadDefinition['files'][] = $includeFile;
+        $autoloadDefinition['files'][] = $this->composer->getConfig()->get('vendor-dir', \Composer\Config::RELATIVE_PATHS) . self::INCLUDE_FILE;
         $rootPackage->setAutoload($autoloadDefinition);

         // Load it to expose the paths to further plugin functionality