search

TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

Respect "installer-name" inside "extra" #34

Closed vandres closed 8 years ago

helhum commented 8 years ago

What is wrong to write a replace section in the composer.json?

vandres commented 8 years ago

Don't know what the recommended way is. "installer-name" is the "composer/installers" way

helhum commented 8 years ago

Don't know what the recommended way is. "installer-name" is the "composer/installers" way

The replaces section works and is respected by the TYPO3 installer. What do you think are the benefits to add the "composer/installers way"?

vandres commented 8 years ago

the benefit is a consistent api for people working with other technologies then TYPO3.

mbrodala commented 8 years ago

@vandres Do you have a specific usecase where the existing logic is not able to determine the correct extension key?

cedricziel commented 8 years ago

I vote for adding this as well. Link to the relevant README entry: https://github.com/composer/installers/blob/41a2376f1c67d1cc3bdf498eaea2f364d02b26f3/README.md#custom-install-names

If I were to maintain 2 project packages named cedricziel/customer1-project and cedricziel/customer2-project i'd expect to be able to have a resulting extension name project in the respective project. In fact cedricziel/customer1-project wouldnt replace project, it then is the project extension.

Apart from that - replace will still work, but I think it's a good idea to stick to the installer-name convention.

helhum commented 8 years ago

If I were to maintain 2 project packages named cedricziel/customer1-project and cedricziel/customer2-project i'd expect to be able to have a resulting extension name project in the respective project. In fact cedricziel/customer1-project wouldnt replace project, it then is the project extension.

Sounds fishy and like an edge use case ;)

It is also not where we are heading. The goal is, that TYPO3 works whereever an extension is installed and whatever its directory name is. So I'd like to not add another way to configure the extension key.

helhum commented 8 years ago

It is btw. now possible to configure the extension directory to be the package name and set up the required directory structure manually. Besides that, I finally documented the options, requirements and behavior of the installer in the README, to get people from other technologies on board more easily.

helhum commented 7 years ago

Uhm, better late than never, right? :)

vandres commented 7 years ago

wohoo :D Thanks

cedricziel commented 7 years ago

Great, thx! :)