search

TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

Catch exception while installing TYPO3 extension #58

Closed sascha-egerer closed 4 years ago

sascha-egerer commented 7 years ago

If a TYPO3 extension has modified files while running composer update the process ends hard with an exception and not further changes are made. Exceptions should be cachtched so the process can continue and update at least all other packages

helhum commented 7 years ago

so the process can continue and update at least all other packages

for me the question is, how the composer library installer handles that case. I tried it and when --no-interaction is specified, the installation / update is stopped, which, from a package manager perspective, is the safest thing to do.

So if there are setups where this imposes a problem, these setups should be modified.

sascha-egerer commented 7 years ago

I think that depends on the option discard-changes https://getcomposer.org/doc/06-config.md#discard-changes Is that possible?

helhum commented 7 years ago

Is that possible?

Yes, true. But in any case composer updates the code (changes are discarded or stashed), or it stops execution. The PR here just ignores the changes and leaves the code in undefined state. That might work for edge cases, but may be harmful in other cases.

I'll re-open the pr, but mark it as needs changes.

helhum commented 4 years ago

Anybody wants to pick up this one and work on the open topics?

If not, I tend to close this again.

sascha-egerer commented 4 years ago

I'm fine with closing it.