search

TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer
GNU General Public License v2.0
58 stars 39 forks source link

[BUGFIX] Fix extension installation with fixed key #59

Closed mbrodala closed 7 years ago

mbrodala commented 7 years ago

The download location for extension packages can be something like ".../vendor/composer/a205122c/" which does not match the extension key, thus use the first item within $EM_CONF instead and be independent from $_EXTKEY.

helhum commented 7 years ago

There is only one chance to get this in from my PoV and that is changing the parsing code in every location it exists to do exactly what you propose here. until this happens, I'm closing the PR here.

mbrodala commented 7 years ago

OK, totally get that, this needs to be changed in TYPO3 itself first.

helhum commented 7 years ago

OK, totally get that, this needs to be changed in TYPO3 itself first.

The only way to more or less reliably change that is to create a lib that parses ext_emconf and use it everywhere.

On top, we must start throwing exception (disallowing TER upload) on parsing errors of this lib.

This is a lot of effort for changing a format that is dated and for the reason people started ignoring a pretty strict requirement of that format.

mbrodala commented 7 years ago

See #60 for more descriptive errors.