[TASK] Simplify core installer

TYPO3 / CmsComposerInstallers

TYPO3 CMS Composer Installer

GNU General Public License v2.0

58 stars 39 forks source link

[TASK] Simplify core installer #6

Closed mbrodala closed 9 years ago

mbrodala commented 9 years ago

By deriving from the Composer library installer a lot of code duplication can be avoided.

helhum commented 9 years ago

We get tight coupling to composer code by this change (which is bad imho). What do you think are the benefits (besides having a few lines less in our code)?

mbrodala commented 9 years ago

Well, this is a installer for Composer after all. We should not try to reinvent the wheel and benefit from upstream fixes instead.

helhum commented 9 years ago

Imho this is a violation of OOP best practices. I would not include this change