search

TYPO3 / coding-standards

TYPO3 Coding Standards to be used by TYPO3 projects or extensions
MIT License
52 stars 16 forks source link

[TASK] Reformat default PHP-CS-Fixer configuration #118

Closed mbrodala closed 7 months ago

mbrodala commented 8 months ago

Improve Git diff with newlines and have an empty line before "return".

oliverklee commented 8 months ago

It looks like the git message needs a keyword like [TASK] to avoid warnings from the commit message checker.

mbrodala commented 8 months ago

@oliverklee Not sure what this means here, my commits always use the TYPO3 CGL commit prefixes. Does the PR title need this too? That'd be unexpected at least.

mbrodala commented 8 months ago

Yup, it was the PR title, not the commit messages. Weird, but whatever. :shrug:

mbrodala commented 7 months ago

@oliverklee Can you have another look?