search

TYPO3 / coding-standards

TYPO3 Coding Standards to be used by TYPO3 projects or extensions
MIT License
52 stars 16 forks source link

Publish latest state supporting symfony 7 #125

Closed DanielSiepmann closed 3 months ago

DanielSiepmann commented 3 months ago

Is there an existing issue for this?

Is your feature request related to a problem? Please describe

We currently can not use symfony 7 in extensions when requiring latest stable release of the coding standards.

Describe the solution you'd like

The coding standards already have v7 support in current main branch, but the change was not yet released. A release would be welcome in order to update and make use of it.

Describe alternatives you've considered

We could require the dev branch, but that's a moving target within extensions which do not have a lock file.

Additional context

No response

bmack commented 3 months ago

Yes. Would love to do, as soon as the tests are green. I have been working for quite a few hours in the past months to make this package ready for a new version, but I'm currently on my own here.

oliverklee commented 3 months ago

@bmack Would you appreciate help (in the form of PRs)?

And as far as I can see, the two CI workflows are disabled due to inactivity: https://github.com/TYPO3/coding-standards/actions/workflows/continuous-integration.yml Would you be willing to re-enable them so it's easier to see what is failing?

bmack commented 3 months ago

Thanks @oliverklee !

Yes, I'd appreciate help in form of PRs. I also did some work in update-rules branch. I also re-enabled the Workflow.

oliverklee commented 3 months ago

Thanks!

As far as I can see, CI currently is green: https://github.com/TYPO3/coding-standards/actions/workflows/continuous-integration.yml

Which tests are currently not green? Where can we help?

bmack commented 3 months ago

Running 

git clone git@github.com:TYPO3/coding-standards.git
composer install
composer ci:php:unit

Throws errors for me.

oliverklee commented 3 months ago

Hm, I wonder why this doesn't show up on CI …

Anyway, I've fixed it: #126

bmack commented 3 months ago

Yes. but phpstan still has some issues.

oliverklee commented 3 months ago

but phpstan still has some issues.

AFAICS, that's with the nightly version of PHP only. To me, the failures look more like a problem of PHPStan, and not like a problem with our codebase.

I propose running only the PHP linting and the unit tests with all PHP versions, and run PHPStan only with exactly one (released) PHP version. (I'd be willing to take care of that.)

What do you think?

oliverklee commented 3 months ago

I also did some work in update-rules branch.

I can take care of extracting the unrelated parts of the branch into separate PRs.

bmack commented 3 months ago

Just released 0.8.0. Thanks for your support @oliverklee !