search

TYPO3GmbH / ext-hubspot

GNU General Public License v2.0
5 stars 5 forks source link

[Task] Add v 11 compatibility #5

Open pgreban opened 2 years ago

pgreban commented 2 years ago

Added compatibility for v11 while keeping compatibility for older versions

mabolek commented 2 years ago

@pgreban Thank you for the PR! I ran the CI workflow and it seems to be a problem with unit tests in v11. It looks Guzzle-related.

pgreban commented 2 years ago

I think I know where it comes from. I need to find a way to keep the compatibility for older versions.

pgreban commented 2 years ago

Why are some tests canceled? For example 9.5/7.4

mabolek commented 2 years ago

If a certain amount of checks fail, others are simply stopped. Saves CPU time.

Rall3n commented 2 years ago

As a user who has encountered problems with TYPO3v11 and this extension I believe the problem is the old age of the Hubspot PHP Interface included as a .phar file.

Even though the library includes its own Guzzle implementation (~6.0), it falls back to the TYPO3 Guzzle dependency, which is a more recent version (^7.3.0). Therefore it throws issues due to now non-existent functions and/or classes (either on TYPO3 or Hubspot-PHP site).

You would have to update the included Hubspot-PHP library (and the composer dependency) to its newest version for v11 compatibility.

mabolek commented 2 years ago

Hi @Rall3n!

Have you tried running the extension in a Composer-based TYPO3 installation?

I think the long-term solution is to drop support for non-composer installs. The extension is currently supporting a wide range of TYPO3 and PHP versions, which makes it hard to include any libraries in the package without compatibility issues.

Rall3n commented 2 years ago

Hi @Rall3n!

Have you tried running the extension in a Composer-based TYPO3 installation?

I think the long-term solution is to drop support for non-composer installs. The extension is currently supporting a wide range of TYPO3 and PHP versions, which makes it hard to include any libraries in the package without compatibility issues.

Unfortunately the system I require this extension for is not running in composer mode, and conversion is not an option.

It may be the right decision maintenance wise, but removing TER support would abandon everyone who is not able to use composer on their servers/webhosts.

Lefaux commented 2 years ago

just as a sidenote here: composer is not supposed to run on the webserver in the first place ;-)