TYPO3GmbH / ext-hubspot

GNU General Public License v2.0
5 stars 5 forks source link

Broken compat with TYPO3v8 due to Environment usage #7

Open mbrodala opened 2 years ago

mbrodala commented 2 years ago

Bug Report

Prerequisites

Description

Any action is broken:

  [ Error ]                                          
  Class 'TYPO3\CMS\Core\Core\Environment' not found  

Exception trace:
#0 ()
   typo3conf/ext/hubspot/ext_localconf.php:13
#1 TYPO3\CMS\Core\Utility\ExtensionManagementUtility::{closure}()
   typo3conf/ext/hubspot/ext_localconf.php:54

This is caused by the usage of the Environment class which does not exist in TYPO3v8.

Steps to Reproduce

  1. Do any thing on CLI/BE in TYPO3
  2. See the error

Expected behavior: There should be no error

Actual behavior: There is an error

Versions

2.1.1

mabolek commented 2 years ago

Hi @mbrodala!

I think I fixed this some time ago, but it's still in the develop branch. Does the develop branch work for you?

mbrodala commented 2 years ago

You mean due to https://github.com/TYPO3GmbH/ext-hubspot/commit/4dac6ff16c0004fb943a1d6dba6e105618e8a510? I'll try ASAP.

mbrodala commented 2 years ago

Yup, this fixes the error as expected. :+1: