search

TYPO3GmbH / ext-usercentrics

This extension integrates Usercentrics (Compliance and Consent Management) into TYPO3.
GNU General Public License v2.0
4 stars 6 forks source link

Wrong information in Readme #11

Closed Ragna-30988 closed 4 years ago

Ragna-30988 commented 4 years ago

I integrated your extension in a typo3 system and had to fetch that you have a mistake in your readme.

In Configure the JS Files to be handled by Usercentrics: you use the attribute dataProcessingService which causes an error in the frontend of my page.

Oops, an error occurred!
No valid identifier given for file, please check TypoScript configuration.

More information regarding this error might be available online.

The Reason is, that in your function T3G\AgencyPack\Usercentrics\Hooks\PageRendererPreProcess::isValidIdentifier you are checking the index dataServiceProcessor. This is the reason the exception is thrown.

In your last commit you changed the readme.

Did you just forget the class or is it really a mistake in the readme?

NeoBlack commented 4 years ago

Not only wrong information, but there are also some more confusing things. We have to check and get streamlines the options dataProcessingService and dataServiceProcessor In ViewHelper, TypoScript and Controller both means the same, but are used with different wording. I suppose to streamline the usage and deprecate one of the wording/settings and use only once.

NeoBlack commented 4 years ago

"Data Processing Services" is the correct woring, so wie should go with dataProcessingService