search

TYPO3incubator / surfcamp-team3

SurfCamp Team 3 - Restaurant Website (andy)
GNU General Public License v2.0
0 stars 0 forks source link

Record: Menuteaser #93

Open anastasijamitrovic opened 2 months ago

anastasijamitrovic commented 2 months ago

Fields: Headline Text Inline element https://www.figma.com/file/cFHtHNzXjcLlRHvl7rFvzH/Wireframing-in-Figma?type=design&node-id=0-1&mode=design&t=Eukway1WSr6MxeAF-0

dzdavidferro commented 2 months ago

MenuTeaser CE has been implemented to the PROD: https://team3.surfcamp.typo3.com/#c38

lukaszuznanski commented 1 month ago

There is issue with child elements to solve

Alagts commented 1 month ago
  1. Frontend Template: General order: I don't understand why it comes out like it comes... why is the menu item above the actual header of the menu teaser element? See picture:

Image

  1. Frontend Template: Missing fields: Now only header and bodytext are rendered, missing is every field that is permitted, e.g. assets (file processor in TypoScript is also missing), imageorient? (maybe we remove it anyway), subheader .... - we also have to clarify if we really allow every content type here, which I found not useful, especially when we have to style it without a design that shows us how we have to style it.
  2. In the backend itself: The menu items should not pop up above all other BE previews, normally they are located within the content element menu teaser. Rather I would render them with a Data Relation ViewHelper if needed. But then I also would render header and subheader. The rest would flood the backend. See picture:

Image

dzdavidferro commented 1 month ago

The fix has been implemented. Merge request: https://github.com/TYPO3incubator/surfcamp-team3/pull/132

Alagts commented 1 month ago

Please change all issues that I mentioned. The fix #132 is not enough. I checked out the branch and the problems are still there. Only issue 2 was fixed by merge request #132.