TZL0 / pe

0 stars 0 forks source link

Invalid email address allowed #7

Open TZL0 opened 2 years ago

TZL0 commented 2 years ago

The application allows an invalid email address 123@123. image.png

nus-pe-bot commented 2 years ago

Team's Response

Closed since this issue is a duplicate of #2394

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

No exception thrown for a email that violates restrictions

The email restrictions that are stated in the user guide is that the domain portion consist of 2 domain labels separated by a .

However when attempting a command that violates this restriction by adding email nus@nus which is the domain portion should consist of 2 domain labels, the email is successfully added (refer to second screenshot)

This should be a bug as there is no exception caught for this restriction but there is exception thrown for the rest of the restrictions in the diff fields (phone/name)

Screenshot 2022-11-11 at 5.02.16 PM.png

Screenshot 2022-11-11 at 5.01.09 PM.png


[original: nus-cs2103-AY2223S1/pe-interim#2011] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

Flaw is unlikely to affect normal operations of the product as users will only want to record valid email addresses.

This group of bugs can be fixed by fixing the regex checked for emails

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]