NI-PYT: submission of task one

TaIos / comitee

Task from NI-PYT at FIT CTU

MIT License

0 stars 0 forks source link

NI-PYT: submission of task one #1

Closed TaIos closed 4 years ago

TaIos commented 4 years ago

Submitted task passes all tests (also radioactive). The output is not colorful because pytest with MINGW64 terminal on Windows interprets ANSI escape sequences as plain characters. However, all color functionality can be turned on by replacing five click.echo for print in src/printing.py or by switching to feature/colors branch.

hroncok commented 4 years ago

The output is not colorful because pytest with MINGW64 terminal on Windows interprets ANSI escape sequences as plain characters.

Does that also happen when colorama is installed?

TaIos commented 4 years ago

Does that also happen when colorama is installed?

Colorama was already installed:

$ python --version
Python 3.8.2

$ python -m pip freeze
atomicwrites==1.4.0
attrs==20.2.0
certifi==2020.6.20
chardet==3.0.4
click==7.1.2
colorama==0.4.3
idna==2.10
iniconfig==1.0.1
packaging==20.4
pluggy==0.13.1
py==1.9.0
pyparsing==2.4.7
pytest==6.1.1
requests==2.24.0
six==1.15.0
toml==0.10.1
urllib3==1.25.10

MarekSuchanek commented 4 years ago

For me colors are working fine... even in cmd.exe

Tests passed, some feedback for the code:

What if there are more pages than 1000?

https://github.com/TaIos/comitee/blob/5d5784150d2dc86d3273987f772852531eb7069e/committee.py#L86

Such "ternary" if-else statements are not very readable...

https://github.com/TaIos/comitee/blob/5d5784150d2dc86d3273987f772852531eb7069e/src/apply_validation_result.py#L22-L24

Structuring Python project like this (src folder, module-per-class, module-per-function, ...) is not widely used/recommended, but we will learn this next week. (see The Zen of Python)