Apply clippy lints - Githubissues

TaKO8Ki / frum

A little bit fast and modern Ruby version manager written in Rust

MIT License

629 stars 15 forks source link

Closed Br1ght0ne closed 3 years ago

Br1ght0ne commented 3 years ago

Applied Clippy lints with cargo clippy --fix and manually refactored some to make Clippy report 0 warnings :)

Notes:

will every supported shell have completions? if not, changing signature of customize_completions might've been a bad move.

TaKO8Ki commented 3 years ago

@Br1ght0ne

Thank you for your contribution!

will every supported shell have completions? if not, changing signature of customize_completions might've been a bad move.

Yes. frum support bash, zsh and fish now. And I'm planning to support customized fish shell completion.

TaKO8Ki commented 3 years ago

@Br1ght0ne Is this PR still work-in-progress?

Br1ght0ne commented 3 years ago

@TaKO8Ki Forgot to mark as ready. Thank you!