Packages that expose Rust code with `julia_module` fail to precompile with Julia 1.10

Taaitaaiger / jlrs

Julia bindings for Rust

MIT License

408 stars 21 forks source link

Packages that expose Rust code with `julia_module` fail to precompile with Julia 1.10 #112

Closed Taaitaaiger closed 8 months ago

Taaitaaiger commented 9 months ago

I haven't debugged this yet, but what seems to be happening is that it's no longer possible to import JlrsCore and mutate the Main module at precompile time.

Taaitaaiger commented 9 months ago

The big is that you can no longer create constants in other modules (in this case Main) during precompilation. The fix is pretty straightforward:

don't set Main.JlrsCore
use a StaticRef for the reference to JlrsCore in Module::jlrs_core or JlrsCore::module
update code that expects JlrsCore to live Main to use the functions mentioned above

Patch is mostly implementated