search

Taapat / enigma2-plugin-alternativesoftcammanager

Start, stop, restart SoftCams, change setting path
4 stars 7 forks source link

Fixed DreamOS OE-2.5/2.6 images and Add Turkish translation #7

Closed audi06 closed 2 years ago

Taapat commented 2 years ago

Thanks for the proposed changes!

  1. Please fix PEP E265 and E722: https://github.com/Taapat/enigma2-plugin-alternativesoftcammanager/runs/5295133275?check_suite_focus=true
  2. Why are you changing timeout.callback.append to timeout.get().append?
  3. Please try the timeout.callback method first and place the dreambox timeout.connect in the exception. This is an exception for dreambox.
  4. Or return variable from timeout.connect method on dreambox really needed?
audi06 commented 2 years ago

Hello Thank you for your interest. Please try the changes and let me know the result.

Taapat commented 2 years ago

Please try this changes: https://github.com/Taapat/enigma2-plugin-alternativesoftcammanager/commit/29fc2fa0aa7ee388cb32c727c0b5dc747aa92cf1