search

Taapeli / isotammi-addons

Gramps addons for Isotammi project / Isotammen Gramps-lisäosia
8 stars 2 forks source link

ZIPinstall mistakenly believes that multiple .gpr.py files are invalid #7

Open emyoulation opened 2 years ago

emyoulation commented 2 years ago

The ZIPinstall seems to have a validation with a rule that a ZIP may not have more than one .gpr.py Gramps Plugin Registration file. But that is supported by the Gramps registration... both as files registering multiple plugins and as separate registration files for each add-on in a single plug-in folder.

Example: D3 Ancestral and Descendant Charts Type: Web Report - Create ancestral/descendant web based interactive D3 charts.
Author: Matt Keenan
D3Charts.addon.

The CardView addon repository folder is another good example. It has more than a half dozen add view modes and a Gramplet in a single archive. (But since it is in beta and not passed through Peer Review, you might not think of it as a valid test.) In this case, the GitHub system's Code button has a "Download ZIP" pop-up menu option that generates the ZIP file on demand. So it seemed like verifying a GitHub generated download would be a good thing.

kkujansuu commented 2 years ago

Yes, I am aware of the issue. My defense is that initially the Isotammi addons were intended only for the Finnish Isotammi users where we have some control on which addons are used. Specifically ZipInstall was intended to be an alternative way to distribute some of our addons to users - not as a general mechanism to install any addon.

Enhancing ZipInstall to support all features is not trivial.

emyoulation commented 2 years ago

Defense is unnecessary. Your tools need only fit your purpose.

I make suggestions in hopes that they will be easy & be useful to your community too. Any suggestion that does not meet both those criteria can be declined. It won't bother me. I make LOTS of suggestions. Many can (and should be) ignored.