search

TabbyML / tabby

Self-hosted AI coding assistant
https://tabby.tabbyml.com/
Other
21.06k stars 958 forks source link

Should report error when `config.toml` is invalid #2354

Open TennyZhuang opened 3 months ago

TennyZhuang commented 3 months ago

Describe the bug config.toml parsing error is ignored even without a log.

The error produced here, without log

https://github.com/TabbyML/tabby/blob/f573527d2eb9b983cab964e9c9156d24d704a843/crates/tabby-common/src/config.rs#L30-L34

And ignored here

https://github.com/TabbyML/tabby/blob/f573527d2eb9b983cab964e9c9156d24d704a843/crates/tabby/src/main.rs#L71

When user provides an invalid config.toml (This is likely due to extreme lack of doc about the file), they can only see a default configuration applied without any information provided.

Information about your version

main

Information about your GPU Please provide output of nvidia-smi

Additional context Add any other context about the problem here.

wsxiaoys commented 3 months ago

Thanks for sharing the feedback, dup https://github.com/TabbyML/tabby/issues/2228