refactor: panic on invalid config.toml loading

TabbyML / tabby

Self-hosted AI coding assistant

https://tabby.tabbyml.com/

Other

18.26k stars 769 forks source link

Closed darknight closed 1 week ago

darknight commented 1 week ago

Original issue https://github.com/TabbyML/tabby/issues/2228 suggests print warning or error log if config.toml is invalid.

Well, it's viable, what I'm thinking is perhaps stop until config.toml is fixed properly by the user.

This change applies following logic

If config.toml is missing, return default config allow tabby to be started with a Warning mesage
if config.toml is invalid, panic & display error

wsxiaoys commented 1 week ago

We still wanna support a missing config.toml (so tabby can start without any preconfiguration).

Maybe distinguish between a missing config and an invalid config?