search

TabbyML / tabby

Self-hosted AI coding assistant
https://tabby.tabbyml.com/
Other
18.28k stars 771 forks source link

feat: Bash support #2532

Open jtbr opened 5 days ago

jtbr commented 5 days ago

support for bash shell scripting language

I think the only tag type applicable to scripts is function definitions; tree-sitter is all new to me so might want to have a look over that.

Also, while bash scripts commonly end in .sh, they often have no file extension, but are instead identified by the file beginning with #!/bin/bash, #!/bin/sh or similar (they are also normally marked as executable). Not sure if there is any way to support looking for these attributes instead of just the filename.

Summary by CodeRabbit

coderabbitai[bot] commented 4 days ago

Walkthrough

The recent changes introduce support for Bash scripting into the Tabby project. Enhancements include updating configuration files to recognize Bash language, adding a relevant parser dependency, defining function structures, and updating documentation to reflect the newfound support. This integration allows for better handling and parsing of Bash scripts within the Tabby ecosystem.

Changes

Files Change Summary
crates/tabby-common/assets/languages.toml Updated to include top-level keywords specific to Bash scripting.
crates/tabby-scheduler/Cargo.toml Added tree-sitter-bash dependency.
crates/tabby-scheduler/queries/bash.scm Introduced function definition structure in a Scheme file.
crates/tabby-scheduler/src/code/languages.rs Added configuration for the Bash language using tree-sitter-bash in the lazy static block.
website/docs/programming-languages.md Updated documentation to reflect Bash support since version 0.14.0.

Poem

Beneath the stars, where scripts do splash,
Now supports the tongue they call Bash.
With keywords keen and functions clear,
Our code it reads without a sneer.
Documentation sings its name,
In Tabby’s heart, Bash finds its fame.
🐇✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
wsxiaoys commented 4 days ago

it seems the test if failing

Duplicate extension found: sh

Could you try fix it? maybe it's a configuratiohn mistake in config.toml

jtbr commented 4 days ago

seems to be some issue with the tests.. not sure how any of that works...

wsxiaoys commented 4 days ago

Then it seems the tree-sitter-bash implementation is somewhat broken and caused the breakage?

jtbr commented 9 minutes ago

Could be wrong, but I don't think it's the library. The test fails at:

code::intelligence::tests::test_create_source_file

It seems that some test suite does not know how to create a test file in the bash scripting language. I don't know anything about this test suite though.