TabbyML / vim-tabby

Apache License 2.0
38 stars 2 forks source link

Add options when calling node #10

Closed arobase-che closed 4 months ago

arobase-che commented 4 months ago

My use-case is to use openssl CA with the option --use-openssl-ca but there is a lot of options that can be used with node.

icycodes commented 4 months ago

Hi, @arobase-che Thank you for this PR!

I agree that using node options can be useful in some cases, but I think setting your system environment variable NODE_OPTIONS would be a better workaround. On the other hand, loading the system-wide CA certificates will be supported by Tabby Agent as a default feature starting from the next release v1.4.0. Please stay tuned!

Since this repository is for releasing the Tabby plugin for Vim, this pull request will not be merged. If you want to open a new pull request for further discussion, please open it in our main repository TabbyML/tabby. You can find Vim plugin code in clients/vim.

arobase-che commented 4 months ago

I will stay tuned. The NODE_OPTIONS workaround if it works would be an ideal workaround. Thank you.

Understood for the use of this repository. I'm not sure if I will create a Pr on the main repository since, starting from v1.4.0 nobody will have an actual use case for this, although I'm sure someone will at some point.