search

TabbycatDebate / tabbycat

Debating tournament tabulation software for British Parliamentary and a variety of two-team parliamentary formats
https://tabbycat.readthedocs.io/
GNU Affero General Public License v3.0
247 stars 840 forks source link

Results page not auto updating winner of each debate #1456

Open 0zlw opened 4 years ago

0zlw commented 4 years ago

Not sure if this is a known issue (or intentional) but the green/red marker which indicates who won does not update when the marksheets for that particular debate are entered as per the image below. Running v2.3.2 on a chrome browser.

image

tienne-B commented 4 years ago

Don't think it'd be intentional other than if it's a tie or there is no winner. Ties are not normally permitted anyhow. Try refreshing the page? If that doesn't work, check the TeamScore objects for that debate in the database if they exist and have the win field set.

It is possible to mark a ballot/debate as confirmed even without scores because debates are confirmed through Debate objects, ballots through BallotSubmission objects, and while the latter's presence should indicate having score objects, they may be missing, which would be a problem.

0zlw commented 4 years ago

Sorry just to clarify that its a visual issue only, it is fine when you refresh the page.

What I meant was that this occurs when the page automatically updates with the new ballot entries, the other data updates i.e. the cross on the left becomes a tick but the green and red arrows don't change (and possibly the split symbol as well)

tienne-B commented 4 years ago

Oh yes. Need to rule out more serious problems first :)

It would be neat to have the chevrons and result be propagated with the statuses; I'd think it's less intentional than just being more work to set up as more data and connections would need to be used, likewise with refreshing the page once all ballots are confirmed rather than the "Advance" button appearing automatically.

philipbelesky commented 4 years ago

Those win/loss arrows were not setup to live update. As Étienne mentioned, I’m not sure if that information is worth the resources needed to show it live. But, I think this highlights that they could be misleading if the data is updated elsewhere and they appear in the same place as other live data.

Maybe it would be better to remove them or replace them with an “?” if the status changes? That said, it’s probably rare that an updated ballot changes the winner/losers so it may not be worth compromising the standard use case.

0zlw commented 4 years ago

Thanks for your responses - I agree it's not a big deal but wanted to check it was an intentional decision (i.e. due to resources). The result changing would seem to me to be extremely rare so I think that would be fine to leave it.