TabbycatDebate / tabbycat

Debating tournament tabulation software for British Parliamentary and a variety of two-team parliamentary formats
https://tabbycat.readthedocs.io/
GNU Affero General Public License v3.0
245 stars 832 forks source link

Extend SpeakerCategory to handle Adjudicators #551

Open philipbelesky opened 6 years ago

philipbelesky commented 6 years ago

So the desired outcome here is to be able to highlight ESL/EFL adjudicators within the Edit Adjudicators screen. Extending SpeakerCategory might be the easiest way to do that.

At the same time this might be useful also in other circumstances, such as SuperAdjudicators / Unaccredited in the NZ system or being able to add arbitrary categories (that could then be highlighted) in Edit Adjudicators interface.

czlee commented 6 years ago

We should probably knuckle down on the use-case before implementing this, specifically whether it should be an extension of speaker category or just its own thing. Speaker categories currently automatically generate special tabs ranking speakers, which I assume is not a great idea for marking super-adjudicators or trainees. Also, "unaccredited" currently has a special meaning that isn't amenable to generalisation (it prevents the adjudicator from being auto-allocated). At the same time, maybe we want speaker and adjudicator categories to be the same thing, in order to align the two during adj allocation.

If all we want to do is tag adjudicators, it might be that an arbitrary comma-delimited "tags" field is more appropriate, or maybe the model should be called a "tag" and then behave like one (i.e., do nothing except exist and sometimes show up in interfaces).

philipbelesky commented 6 years ago

Hmm yea, SpeakerCategory isn't shown on the Edit Adjs page as-is; only the relevant Break Category. So the example outlined above doesn't actually work.

The tags example sounds like a more broad solution although don't do great on the particular ESL/EFL example, in that the highlighting should ideally (a) show at the same time Break status is toggled and (b) use the same color scheme. If we just need a solution for the ESL/EFL use case there could almost be a PreferredAdjudicatorForCategory style many to many on each BreakCategory but not sure if its worth adding just for this case.

czlee commented 6 years ago

Yeah, I feel like this will have no real use outside WUDC?