TablePlus / TablePlus

TablePlus macOS issue tracker
https://tableplus.com
3.39k stars 56 forks source link

Metrics board multiple input field / dropdowns possible? #3302

Closed Maddoc42 closed 4 months ago

Maddoc42 commented 4 months ago
  1. Which driver are you using and version of it (Ex: PostgreSQL 10.0):

PostreSQL 14.10

  1. Which TablePlus build number are you using (the number on the welcome screen, Ex: build 81):

Build 550

  1. The steps to reproduce this issue:

It looks like only one of the two input values is being submitted to the query, the other is empty, hence the syntax error.

Is it not possible to have multiple inputs connected to a single chart?

huyphams commented 4 months ago

You should be able to chain multiple inputs like this. But somehow it does not work as expected. Going to fix it.

Screenshot 2024-05-16 at 5 14 27 PM
huyphams commented 4 months ago

Hmm, after close and reopen metrics board, it works as expected, maybe the issue only happens for the first time we create chained input. @Maddoc42

huyphams commented 4 months ago

The event in Metrics board is push only (not pull), so you cannot have more than 2 signals to chart at a time. Instead of doing that, you can chain multiple inputs as above. @Maddoc42

Maddoc42 commented 4 months ago

Thanks for taking the time @huyphams ! 🙏 I was able to create a input chain as you suggested. This requires all inputs except the last in the chain (2 in your example) to be configured as "Submit on Event", is that correct? As a result the chart will only update when submitting the last input. This works, just a bit unintuitive to use.

Happy to say the charts are the reason we renewed our license btw., love this! 😊

Maddoc42 commented 4 months ago
Screenshot 2024-05-16 at 14 51 31

The above fix only seems to work with inputs, not with dropdowns. Configured "Submit on Event" on 1, yet changing 2 never triggers anything. Restarting TablePlus doesn't help either. Is there anything else we can try?

huyphams commented 4 months ago

@Maddoc42 currently there is a bug where the first time you created it will not work, but after you close and reopen the metrics board, it will work. We fixed the bug and will release an update this month!

Maddoc42 commented 4 months ago

@huyphams yes, I can reproduce this when chaining regular inputs. With dropdowns restarting does not seem to help.

huyphams commented 4 months ago

Hi @Maddoc42 we fixed that bug too, please wait for the next update!

Maddoc42 commented 4 months ago

Thank you so much, this is awesome! 🙏

Screenshot 2024-05-16 at 16 10 13

Hijacking this thread (happy to open another if that's better), a small QOL improvement request if possible: when clicking on a data point in a chart, the selected point is highlighted with dotted lines. Any chance to see the numeric values for that point? Right now getting the value means zooming in the chart until only the single data point is visible.

huyphams commented 4 months ago

In the query result, it will show the value below the chart, we can bring it to metrics board too. Thanks for the feedback.

Screenshot 2024-05-16 at 9 14 37 PM

huyphams commented 4 months ago

the chain inputs issue is fixed on production now!