TablePlus / diagram-plugin

111 stars 10 forks source link

[bug] Import sample doesn't work properly #12

Open mittalyashu opened 4 years ago

mittalyashu commented 4 years ago

There was some existing data in one of the page (IDK what you guys call it, page, maybe) and when I try the import sample feature.

I remove all of the existing data and didn't added any sample data on top of it. Well, in the first place I think it should not replace or overwrite the data, and create a new page.

CleanShot 2020-10-23 at 09 33 34

thien-do commented 4 years ago

remove all of the existing data [...] Well, in the first place I think it should not replace or overwrite the data, and create a new page.

Well this is the expected behavior :( This is why we called it "Import" instead of "Open". I think it's a common naming.

Anyway, we will try to think of a way to support both if possible

didn't added any sample data on top of it

This, however, is indeed a bug. We will need to take a look at it. Unfortunately the current "Report issue" feature is being buggy so I can't ask you for a sample data :(

mittalyashu commented 4 years ago

This is why we called it "Import" instead of "Open"

In that case, should it just append the data instead of replacing the data, there can be cases where users might have not even saved their changes.


Just a general question, why don't you guys built the plugin in native language just like the application itself?

thien-do commented 4 years ago

In that case, should it just append the data instead of replacing the data, there can be cases where users might have not even saved their changes.

Yeah we already have that option (but hide it). Let us see turning it on :+1:

Just a general question, why don't you guys built the plugin in native language just like the application itself?

There are several reasons but the one I can share is that we'd love to build an open, cross-platform plugin system (the plugins are used in TablePlus Mac and Windows without any modification, with Linux coming soon).

Another important reason is that for some specific jobs like this, we believe the web platform is mature enough.