TablePlus / diagram-plugin

111 stars 10 forks source link

[bug] Add new column to table #5

Closed mittalyashu closed 4 years ago

mittalyashu commented 4 years ago

Once creating new table, I am not able to add new column, or delete an existing column from table.

CleanShot 2020-10-20 at 06 39 39

thien-do commented 4 years ago

I'm sorry this is really bad. We are trying to reproduce. Is that Mac or Windows or Web version?

mittalyashu commented 4 years ago

@dvkndn

OS: MacOS 10.15.7 TablePlus version: 342

Not sure, how to get the diagram plugin version.

thien-do commented 4 years ago

Yes this is enough. We are still trying to reproduce the issue. Look like it only happens with the Mac plugin :(

mittalyashu commented 4 years ago

@dvkndn

Quick question, does the type column shows any recommendations and if it does, is it database specific?

thien-do commented 4 years ago

Quick question, does the type column shows any recommendations and if it does, is it database specific?

@mittalyashu currently not. We plan to have it in the near future, and yes it should be database specific

That being said, it's likely that it will only be "suggestion" (i.e. no enforcement)

thien-do commented 4 years ago

Hi @mittalyashu sorry for the issue. Please try again with latest version (3.6) of the diagram plugin (Cmd/Ctrl + L to check for plugin update). It should be fixed now :D

mittalyashu commented 4 years ago

@dvkndn I am already using build version 3.9.1 (342)

thien-do commented 4 years ago

@mittalyashu that is the TablePlus's version. The diagram plugin has its own versioning, which can be seen in the Plugin Manager window (CMD + L). Can you see if there is any update in the Plugin Manager?

mittalyashu commented 4 years ago

@dvkndn I have updated it to version 3.7 as of current date (22 October 2020)

thien-do commented 4 years ago

@mittalyashu sorry, just to confirm, it still doesn't work (you can't create new column) in version 3.7 of the diagram plugin?

mittalyashu commented 4 years ago

I haven't tried it out, let me give it a quick try.

thien-do commented 4 years ago

thank you!

mittalyashu commented 4 years ago

@dvkndn Working for me. Is that the expected behaviour?

CleanShot 2020-10-22 at 15 48 14

thien-do commented 4 years ago

Yes that's correct behavior, thank you :D But please feel free to provide any feedback if you want. We also want that after clicking "add" then the newly added column would be automatically focused

mittalyashu commented 4 years ago

@dvkndn There was this another issue in the previous version (which I have previously installed) where the line was overlapped by table.

Maybe it might have been fixed in the newer version.

CleanShot 2020-10-20 at 06 37 20@2x

thien-do commented 4 years ago

@dvkndn There was this another issue in the previous version (which I have previously installed) where the line was overlapped by table.

Ah sorry, not yet :( but it's more like our current behavior. At the moment we choose to place the Tables over the References. Let me try having the opposite and see if it's better. To be frank, we haven't had a strong opinion about this yet

mittalyashu commented 4 years ago

@dvkndn

At the moment we choose to place the Tables over the References.

As far I understand the canvas (well, I don't even know how this plugin is build) has infinite space so just push the table bit further away so that the references doesn't over lap the tables.

And I mean by the above image.

NOTE: The above image was taken after the table arrangement was done by plugin automatically, I didn't change their positions.

CleanShot 2020-10-23 at 09 18 49@2x

Not this 👆

thien-do commented 4 years ago

As far I understand the canvas (well, I don't even know how this plugin is build) has infinite space so just push the table bit further away so that the references doesn't over lap the tables.

This is a very reasonable approach :D Unfortunately our current "layout" algorithm is not quite as good. Let us improve it. You are right that the layout should put the tables to minimize the overlaps

thien-do commented 4 years ago

Hi @mittalyashu I created a new issue to keep track of the above problem at #15 . Since the original issue (bug that cannot add new column) is addressed, can you help me closing this issue? We will continue at #15