In 2024.06.01, we added damage types. And we also allowed the ability to regulate allowed damage types within a rule system (loosely enforced).
We hastily implemented the auto-suggest for damage types, and so didn't use async philosophies or one-off calculations. That is, we calculate the damage types for autocomplete in the rendering (which is bad practice).
We should instead use the async pipe and compute the damage type suggestions once, rather than over and over.
In 2024.06.01, we added damage types. And we also allowed the ability to regulate allowed damage types within a rule system (loosely enforced).
We hastily implemented the auto-suggest for damage types, and so didn't use async philosophies or one-off calculations. That is, we calculate the damage types for autocomplete in the rendering (which is bad practice).
We should instead use the async pipe and compute the damage type suggestions once, rather than over and over.