Tabletop-Mirror / Issues-and-Tasks

0 stars 0 forks source link

Fix Potential Double Application of Bonuses #115

Open VarunS1997 opened 2 weeks ago

VarunS1997 commented 2 weeks ago

Because we used to not expect Bonuses from parent evaluators to inherit into descendant evaluators, but they now do, targeted bonuses can double apply if they are applied in both the parent and child.

This is likely a big problem because of things like sub-abilities where the benefit is applied to both the parent ability evaluator, but also to that parent ability's parent (like a character template level).

Now, as long as you don't query the child evaluator (in the example above, the parent ability's evaluator), then you can't see this bug. But it could mean weird and erroneous calculations (and possible infinite calculations...?)