Make `CustomStringConvertible` tests more resilient

TabletopAssistant / DiceKit

Swift framework for expressing and evaluating dice notation (e.g., d20, 4d6+4, 3d8×10+2), which is commonly used in tabletop role-playing games.

Apache License 2.0

14 stars 1 forks source link

Make `CustomStringConvertible` tests more resilient #113

Closed brentleyjones closed 8 years ago

brentleyjones commented 8 years ago

If we ever change the outcome type, then the strings won't content Constant(2) anymore. This change makes the unit tests focus on the exact thing they are trying to do. They don't care how individual things are printed, just how they compose those things.

brentleyjones commented 8 years ago

@JonathanHoffman Assigned to you since the code was originally yours.

JonathanHoffman commented 8 years ago

I just had a minor comment about consistency of returning the CustomStringConvertible and a comment on an unrelated typo.

:+1: