search

TabletopAssistant / DiceKit

Swift framework for expressing and evaluating dice notation (e.g., d20, 4d6+4, 3d8×10+2), which is commonly used in tabletop role-playing games.
Apache License 2.0
14 stars 1 forks source link

Typealias `ExpressionResultValue` #117

Closed brentleyjones closed 8 years ago

brentleyjones commented 8 years ago

By having this be a type that can change later it makes it simpler to change to something dealing with Success checking.

Also renamed ExpressionResultType.value to ExpressionResultType.resultValue. This prevents name collisions with commonvalue properties that types commonly have.

brentleyjones commented 8 years ago

@JonathanHoffman I would like you to review this one as well. It's not in your areas like the last two, but it's a big enough change I would like your take on it.

JonathanHoffman commented 8 years ago

:+1: