Probability mass

[brentleyjones]

Closes #58.

• FrequencyDistribution
  • [x] Type
  • [x] Tests
• ProbabilityMass
  • [x] Type
  • [x] Tests
• ProbabilisticExpressionType
  • [x] Protocol
  • [x] Tests
• Probability documentation
  • [x] Usage in README
  • [x] Probability page in playground

I'm not doing the equality tests as part of this. I want to refactor those so they are very easy to test for anything that implements Equatable (#54).

[JonathanHoffman]

adding two discrete variables is more like xor I think? Multiply is like P(both of these happen) so I think and is appropriate. I don't know if we want a more descriptive function name. Let me get back to you after coffee.

[brentleyjones]

They aren't exactly xor or or, so or fits better when thinking of saying the following: "I can get heads or tails" or "I can get 1 or 2 or 3 or 4 or 5 or 6". It's a way to build it up. Similar is "I can get (heads or tails) and (heads or tails) and (heads or tails)".

[brentleyjones]

I see how it is actually xor. I'll think on that one. I think xor makes sense for probability, but most people think of it as "or" verbally. So the inner one can be xor while the outer operator can still be be || maybe?

[brentleyjones]

Ignore all of the above, I renamed it to xor and made a logical xor operator ^^.

[brentleyjones]

@TabletopAssistant/dicekit This is ready for code review. I'll do the documentation and playground in the next day or two (and I'll ping everyone again then).

[JonathanHoffman]

I think the names for the methods are fine. I only pointed out code style things. Other than that, :+1:

[JonathanHoffman]

Also, README and Playground. Just noticed that they are still on your list.

[brentleyjones]

Finally got around to updating the playground. It made me implement some protocols to make it easier to use. I love playgrounds.

[brentleyjones]

@LoganJohnson @JonathanHoffman Ready for final review :tada:

[brentleyjones]

I realized that I need to add tests for the new SequenceType/CollectionType conformance I have/am adding.

[JonathanHoffman]

Wow, I've never seen a frequency distribution like that! Very nice!

[brentleyjones]

Ready for final code review. All tests in. Playground up and running. :dash:

[LoganJohnson]

:+1: Super pumped to see this stuff in action. That probability graph in the playground is the bees knees.

[brentleyjones]

I'll fix the typo soon, then merge if no other comments come up.