search

TabletopAssistant / DiceKit

Swift framework for expressing and evaluating dice notation (e.g., d20, 4d6+4, 3d8×10+2), which is commonly used in tabletop role-playing games.
Apache License 2.0
14 stars 1 forks source link

Add convenience functions #44

Closed JonathanHoffman closed 9 years ago

JonathanHoffman commented 9 years ago

TO DO:

This PR closes #34 and closes #35.

brentleyjones commented 9 years ago

All my comments for now. Mostly code style stuff (which makes me want to do the style guide even more, but most can be picked up from the surrounding code for now). Small testing tweaks as well.

JonathanHoffman commented 9 years ago

I have encountered an issue with implementing an operator overload for NegationExpressions. This operator will return a NegationExpression<Int> when applied to an Int, which is bad. The other operators have tests to show that this doesn't happen in their case. Implementing a convenience operator for NegationExpression will have to wait. @brentleyjones should open an issue!

JonathanHoffman commented 9 years ago

Ready for review and merge.

edit: I can squish some commits together too. I'll do that later.

brentleyjones commented 9 years ago

Can you update usage and the playground pages?

JonathanHoffman commented 9 years ago

Certainly. :pencil2:

brentleyjones commented 9 years ago

Everything looks solid, just some comment on code style. I'm looking forward to the playground changes.

brentleyjones commented 9 years ago

This looks great now :+1:. When both then CI tests pass go ahead and merge it.

JonathanHoffman commented 9 years ago

That was fun!