Add CustomDebugStringConvertible and CustomStringConvertible conformance - Githubissues

TabletopAssistant / DiceKit

Swift framework for expressing and evaluating dice notation (e.g., d20, 4d6+4, 3d8×10+2), which is commonly used in tabletop role-playing games.

Apache License 2.0

14 stars 1 forks source link

Add CustomDebugStringConvertible and CustomStringConvertible conformance #55

Closed JonathanHoffman closed 9 years ago

JonathanHoffman commented 9 years ago

Progress!

TODO:

[x] implement CustomStringConvertible and CustomDebugStringConvertible to the Expression types.
[x] write a playground page exploring these types, their strings, and their developer friendliness. (what would you like to see in such a page?)

Closes #50

brentleyjones commented 9 years ago

I find its nice to make a playground to explore these.

How about adding a page that showcases how dev friendly our types are? The first section can be on these two conformances. Later we can add a QuickLook section?

brentleyjones commented 9 years ago

I don't think there is much boilerplate at all. It's just the way they work. So, overall, :+1:.

JonathanHoffman commented 9 years ago

I really like the idea of writing a page for this! I can cover how dev friendly everything is while giving an idea of why each type exists and how to use them. It will also help people understand what to expect from each type without reading all the tests (see my MultiplicationExpressionResult goof).

brentleyjones commented 9 years ago

A couple small things, but overall I like it. :sparkles:

brentleyjones commented 9 years ago

I really liked the playground. Great job! :sparkles:

brentleyjones commented 9 years ago

Just the one revert, then good to merge :+1: