TabletopAssistant / DiceKit

Swift framework for expressing and evaluating dice notation (e.g., d20, 4d6+4, 3d8×10+2), which is commonly used in tabletop role-playing games.
Apache License 2.0
14 stars 1 forks source link

probabilityMass for a negative sided die. #91

Closed LoganJohnson closed 8 years ago

LoganJohnson commented 8 years ago

The range for a negative sided die was going up to 1 instead of stopping at -1. Fixing that.

If there's thoughts for more/better testing ideas for this let me know.

LoganJohnson commented 8 years ago

I'm not authorized to see the details of the CI build. Any chance I can get that?

brentleyjones commented 8 years ago

Limited spots, sorry. I have an open request to allow open source projects to show to the public. I'll let you know what it is in a bit.

brentleyjones commented 8 years ago
Test Case '-[DiceKitTests.Die_Tests test_probabilityMass_shouldReturnCorrect]' started.
*** Failed! Proposition: probability mass
Falsifiable (after 4 tests):
-2
*** Passed 3 tests
.
/Users/vagrant/git/DiceKitTests/Die_Tests.swift:404: error: -[DiceKitTests.Die_Tests test_probabilityMass_shouldReturnCorrect] : failed - Falsifiable

Need to fix the other test as well.