search

TabrizPlv / pe

0 stars 0 forks source link

Order in which tags are added are not the same as user's input #12

Open TabrizPlv opened 1 year ago

TabrizPlv commented 1 year ago

image.png

When i use the command t undead zombie, the tags are added in the order zombie, then update. This does not correspond to the user's input. The UG does not warn of this as well.

soc-se-bot commented 1 year ago

Team's Response

This seems to be a cosmetic gripe. Tags are ordered according to lexicographic order, which allows for the UI to display them in a more visually pleasing way. (i.e. {undead, elite} and {elite, undead} should be displayed in a consistent manner in the UI, which it is with this implementation).

Additionally, functionally there is no difference for the user as tags are treated as a set where order does not matter, and are generally understood to be as such since there should be no difference even from the user's POV regarding an entity tagged as {undead, elite} VS {elite, undead}, i.e. both are undead and elite.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: I believe that there is a functional difference in terms of user experience. As a user, when I want to add tags, I'd want to add them in order of priority as settled by me. As such, I will add the tags in order of priority as I want the most important ones to be at the top. Having the product change this order for me without any warning can be quite appalling.

## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** I believe that this is not just a cosmetic issue. This disrupts the user's experience without any prior warning.