search

TabrizPlv / pe

0 stars 0 forks source link

Deleted Items still show up in the inventories of Characters #14

Open TabrizPlv opened 1 year ago

TabrizPlv commented 1 year ago

If i add Bow to a Character inventory, then delete the Bow, the Bow still appears in the Character Inventory

nus-pe-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Updating Items Does Not Update Character Inventories

CostNotUpdated.PNG

As seen above, there are two bows with two different cost (value) even though only one Bow item entity exists. If the name of Bow is changed to Not Bow, the inventories do not update as well.

This is problematic as the user believes that the items in the inventories are related to the items in their entity list.

Hence, if they want to update the value of a sword (due to story reasons like increased war item demand), they will need to delete and add items to update their value.

Common troupes of a rusty sword becoming a legendary sword is also common, but cannot occur here by just editing the rusty sword to a legendary sword. Instead the user must delete the rusty sword and add a legendary sword instead.

This is inconvenient and reduces usefulness of the edit item feature.

[original: nus-cs2103-AY2223S2/pe-interim#2449] [original labels: severity.Medium type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

While some users might believe that the items in the list is linked to their inventory, in terms of gameplay, it does not necessarily make too much sense. The coordinator might choose to change the stats or name of an item they want to track, but this does not correlate to the player having their item mysteriously changed, the version of the item that the player holds should remain exactly the same as before. A more problematic extension of this is to delete an item from the entity list which might have been done as it is discontinued. Similarly, this should not correlate to the player losing the item they already have.

Future enhancements may involve expanding the item to see its details and possibly the date added (version) to make this feature more fleshed out.

Additional feature to specifically link item in entity list to inventory at point of addition may also be implemented. Our team decided that the current behaviour of inventory is more likely in normal gameplay and thus take precedence over the issue mentioned. Additionally, as of now, due to current implementation, there is no way to have "linked" items without performance loss and these features have to be part of future improvements.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

## :question: Issue response Team chose [`response.NotInScope`] - [x] I disagree **Reason for disagreement:** I believe that the reasoning given by the dev team is not convincing enough. This app is meant to be used by an individual TTRPG player to track his **personal** inventory/items. Thus, it should not matter what a `coordinator's` actions are as the `coordinators` should not be able to influence the data of a tracked item inside the user's app. Furthermore, none of these issues were surfaced as planned improvements under the appendix in the DG.
## :question: Issue type Team chose [`type.FeatureFlaw`] Originally [`type.FunctionalityBug`] - [x] I disagree **Reason for disagreement:** I believe that this is a `FunctionalityBug` because it does not work as expected. Also, it does not work as expected because the delete function states that the delete function `Deletes the specified entity from Reroll’s database`. If the entity is removed from the database, it should not still appear in the user's inventory.