Open TabrizPlv opened 1 year ago
Thanks for spotting this!
This issue was actually brought up during the PE-D. While it is true that we did not account for it originally, our team thought about it and felt that this was not something that needs fixing (hence it was not mentioned as a feature flaw in the DG). For example, in the context of the game, one may have an item named iron sword
and a separate glitched item named iRoN sWoRd
.
Hence, this behaviour is expected in the context of the app.
Team chose [response.Rejected
]
Reason for disagreement: Considering the context of the app, there can be better ways to show a glitched item other than through its name. Even if the dev team is insistent on using the name, I believe that allowing such duplicates to exist is too huge a sacrifice as it negatively impacts the user's experience. For example, since the names are not case-sensitive, all other commands will also have to be case-sensitive since they have to remember the specific casings of the name of the entity in order to interact with them through the commands.
Reroll does not detect duplicates when there are same inputs, but different casings. It is reasonable to expect that two
Characters
with the sameName
refer to the sameCharacter
even if their names are not in the same casing. For example,make char Bob
followed bymake char BOB
creates two differentCharacters
with NamesBob
andBOB
respectively