[Rule Submit] NAME: Attribute names should not have '_' '/' '\\'

TabularEditor / BestPracticeRules

An official collection of standard Rules for use with Tabular Editor's Best Practice Analyzer.

120 stars 53 forks source link

[Rule Submit] NAME: Attribute names should not have '_' '/' '\\' #17

Closed Gezahegne closed 4 years ago

Gezahegne commented 7 years ago

"ID": "NAME:_ATTRIBUTE_NAMES_SHOULDN'T_HAVE_'_'_'/'_'\\'",
"Name": "NAME: Attribute names should not have '_' '/' '\\'",
"Category": null,
"Description": "Attribute names should not contain these special characters '_' '/' '\\' You may use camel case or spaces instead for readability.",
"Severity": 3,
"Scope": "DataColumn, CalculatedColumn, CalculatedTableColumn",
"ScopeString": "Columns",
"Expression": "(Name.Contains(\"_\") or Name.Contains(\"\\\") or Name.Contains(\"/\")) and not IsHidden",
"FixExpression": null,
"Compatibility": null,
"IsValid": false

otykier commented 6 years ago

I'd like to start a discussion on the namings. I'm not sure if the standard set of rules for Tabular Editor should disallow the use of slashes in a column name. For example, it is common to have Flag-type columns named like [Yes/No]. Should this be discouraged?

Are we aware of any characters in column names that can cause problems in client tools? Because those should definitely be discouraged.

DaniilMaslyuk commented 6 years ago

I don't think that slashes in field names cause any problems, but I know for a fact that square brackets do.

Also, should this issue be merged with issue #8?

otykier commented 4 years ago

Won't add to standard repository, as this relies on organization-specific naming convention. If there are specific characters that are known to cause problems, please open a new issue.