search

TabularEditor / TabularEditor3

Bug reports, feature requests, discussion and documentation for Tabular Editor 3 (commercial version).
65 stars 7 forks source link

Code Action Loop | Simplifiy 1-variable block <> Move constant aggregation to variable #1386

Closed MarioMue13 closed 3 days ago

MarioMue13 commented 2 weeks ago

Description

the two code actions Simplifiy 1-variable block and Move constant aggregation to variable result in a loop

Tabular Editor 3 Version

3.18.0

Screenshots

image

Steps to Reproduce

No response

Expected behavior

no code action pops up anymore

Crash Report

No response

Windows Version

No response

otykier commented 1 week ago

Thanks for reporting this. While both refactorings are valid and both could be relevant in some cases, it probably makes sense to "downgrade" the "Simplify 1-variable block" from the Readability category to the Rewrites category. By doing this, we would no longer show the 3 dots under the VAR keyword, but the Code Action will still be available when placing the caret on the variable.

otykier commented 3 days ago

Hi @MarioMue13 This is fixed in 3.18.1. Thanks again for reporting!