fixed rowser overlaping issue and crash issue

[la-niina]

The browser had an two major issues overlapping menus and view , and then crashing on input due to onPrepareOptionsMenu method in BrowserActivity. The error message suggests that there is a NullPointerException occurring when trying to invoke the setVisible method on a null object reference.

Pre-launch Checklist

• [x] I read the Contributor Guide and followed the process outlined there for submitting PRs.

• If you made changes to the code:

  • [x] BrowserActivity : I changed the onPrepareOptionsMenu to fix the crash log that was present due to setVisible have left comments t explain the code here is the error and the fix to the crash log below

    2023-05-28 16:09:19.725 15414-15414/com.tachibana.downloader E/ACRA: ACRA caught a NullPointerException for com.tachibana.downloader
    java.lang.NullPointerException: Attempt to invoke interface method 'android.view.MenuItem android.view.MenuItem.setVisible(boolean)' on a null object reference
    at com.tachibana.downloader.ui.browser.BrowserActivity.onPrepareOptionsMenu(BrowserActivity.java:350)
    at android.app.Activity.onPreparePanel(Activity.java:4334)
    at androidx.activity.ComponentActivity.onPreparePanel(ComponentActivity.java:512)
    at androidx.fragment.app.FragmentActivity.onPrepareOptionsPanel(FragmentActivity.java:485)
    at androidx.fragment.app.FragmentActivity.onPreparePanel(FragmentActivity.java:470)
    at androidx.appcompat.view.WindowCallbackWrapper.onPreparePanel(WindowCallbackWrapper.java:100)
    at 

    @Override
    public boolean onPrepareOptionsMenu(Menu menu) {
    BrowserViewModel.UrlFetchState state = viewModel.observeUrlFetchState().getValue();
    
    MenuItem refresh = menu.findItem(R.id.refresh_menu);
    MenuItem stop = menu.findItem(R.id.stop_menu);
    if (refresh != null && stop != null) {
        boolean fetching = state == BrowserViewModel.UrlFetchState.FETCHING ||
                state == BrowserViewModel.UrlFetchState.PAGE_STARTED;
        refresh.setVisible(!fetching);
        stop.setVisible(!fetching);
    }
    
    MenuItem forward = menu.findItem(R.id.forward_menu);
    if (forward != null) {
        forward.setVisible(webView.canGoForward());
    }
    
    MenuItem desktopVersion = menu.findItem(R.id.desktop_version_menu);
    if (desktopVersion != null) {
        desktopVersion.setChecked(viewModel.isDesktopMode());
    }
    
    MenuItem addBookmark = menu.findItem(R.id.add_bookmark_menu);
    MenuItem editBookmark = menu.findItem(R.id.edit_bookmark_menu);
    if (addBookmark != null && editBookmark != null) {
        addBookmark.setVisible(!isCurrentPageBookmarked);
        editBookmark.setVisible(isCurrentPageBookmarked);
    }
    
    return true;
    }

  • [x] All existing and new tests are passing.
  • [x] Updated layouts to fix the overlapping issue changes made in browser_address_bar.xml and activity_browser_bottom_app_bar.xml fixed the issue perfectly comments available to explain the changes made
  • [x]The crash issue on Browser and overlap in the browser search bar are fixed.

[proninyaroslav]

Good job, thank you!