search

Tadaboody / good_smell

A linting/refactoring library for python best practices and lesser-known tricks
BSD 3-Clause "New" or "Revised" License
30 stars 3 forks source link

Don't flatten a nested for with dependencies #26

Closed Tadaboody closed 5 years ago

Tadaboody commented 5 years ago

For example in https://github.com/Tadaboody/good_smell/blob/50c06d9e95884064ad0a1af08c9ea6fd4ee741e6/tests/test_flake8_ext.py#L5-L6 This loop shouldn't be nested because they have a dependency between them - the target of the first loop num