search

Taeir / ContextProject-MIGI2

VR Game
0 stars 0 forks source link

Feature dynamic lights #424

Closed Diocruel closed 8 years ago

Diocruel commented 8 years ago

A bit late, but here are dynamic lights.

All the methods and classes needed for dynamic light placement. It is fully tested, except for the light place methods in RoomNode and RoomLevelFactory, as they will only be reached if the constant of renderTorches is set to true. Since I was not sure to make this a real final constant, I kept it as a normal public static field.

The coverage of the extra lines is above 80%

Credit to where it is due: @Taeir bug fixing @ChielBruin for light loading @WytzeElhorst for the models. (which are already on master)

This closes #394.

Taeir commented 8 years ago

From darkness, into light.

Looking good. Apart from the 2 minor things I mentioned, I think this can be merged.

ChielBruin commented 8 years ago

Looks good! when @Taeir's comments are resolved it can be merged!