TagnumElite / ProjectE-Integration

ProjectE Support for selected mods
https://www.curseforge.com/minecraft/mc-mods/projecte-integration
Other
11 stars 13 forks source link

Immersive Engineering mapper bug #138

Open yeeticus777 opened 3 months ago

yeeticus777 commented 3 months ago

Prerequisites

Details

Description

Its simple, Immersive engineering's metal press mapper is taking precedence over the current existing emc values causing nearly every nugget to cost 1 emc and the ingot to cost 9 emc and the block to cost 81 emc

Expected behavior

Immersive engineering's metal press mapper should only map the emc after the other mods have set their emc vaules for the item, so that the mod doesnt somehow give the item the lowest possible value. I have confirmed this mapper is the issue as turning literally any other mapper of wont effect it but when i turn immersiveengineeringmetalpressmapper off it resets to its normal value, but its the only recipe for crafting ingots blocks and nuggets in my modpack

To Reproduce

Steps to reproduce the behavior:

  1. Turn on [CraftingMapper.ImmersiveEngineeringMetalPressMapper]

  2. Load game and check emc

  3. Wrong emc values

Logs

How would i upload my logs for this, they wouldnt contain this information, a mapping dump or something else would be the only thing that would give you this info i can still give you the latest.log i just dont know if it will do much to help as its not my clients issue and is represented through any version so far for me from 1.18.2-1.20.1

This is purely an error on the behalf of the mod itself, if you want ill decompile the mod and show you exactly what is wrong

yeeticus777 commented 3 months ago

I was originally going to go silent on this but after noticing its happening over three versions its concerning

yeeticus777 commented 3 months ago

In the end ill still fix it by simply overriding the emc values in the custom emc config but its just annoying that i have to do that every modpack

yeeticus777 commented 3 months ago

its literally this line @RecipeTypeMapper(requiredMods = {"immersiveengineering"}, priority = 1)

yeeticus777 commented 3 months ago

Also this is way too broad public boolean canHandle(RecipeType<?> recipeType) { return (recipeType == IERecipeTypes.METAL_PRESS.get());

TagnumElite commented 2 months ago

Are you using a specific mod pack? There might be a mod that's adding recipes to the Metal Press.

Immersive engineering's metal press mapper should only map the EMC after the other mods have set their EMC values for the item, so that the mod doesn't somehow give the item the lowest possible value...

My mapper is only adding conversion patterns (1x Ingot -> 2x Rod). I don't specifically set EMC unless the item doesn't have an EMC at the begging. Even then I set the EMC before which means all conversions overwrite it.

Also this is way too broad public boolean canHandle(RecipeType<?> recipeType) { return (recipeType == IERecipeTypes.METAL_PRESS.get());

its literally this line @RecipeTypeMapper(requiredMods = {"immersiveengineering"}, priority = 1)

This is just how ProjectE RecipeType mappers work.

P.S. Sorry for the horrendous delay in response. Life has been life.

kienerxyzzy commented 1 month ago

Also, I found out that none of the IE engineer's workbench recipes work. The electric components had no EMC value and I had to set them myself.