TagnumElite / ProjectE-Integration

ProjectE Support for selected mods
https://www.curseforge.com/minecraft/mc-mods/projecte-integration
Other
11 stars 13 forks source link

Create mod v0.5.1b 1.18.2 makes the ProjectE mod not work when PEI is installed. #79

Open BerndnixBrot opened 1 year ago

BerndnixBrot commented 1 year ago

Prerequisites

Details

Description

Because of the new Create update v0.5.1b, all blocks and items will no longer have a EMC value when the PEI mod is installed.

Expected behavior

The blocks and items having an EMC value.

To Reproduce

Steps to reproduce the behavior:

  1. Having ProjectE, PEI and Create v0.5.1b in mods
  2. Launch Minecraft and start a world
  3. Try to Transmutate a block or an items

(sorry for the bad english)

Reginald-Halifrax commented 1 year ago

I can confirm this is true. The mod currently errors when attempting to integrate Create. For what little it's worth here is a latest.log in a hyper-limited modpack containing the error.

TagnumElite commented 1 year ago

Thanks for the log. Sadly I've been without a computer for weeks now. I sadly can't do anything about it currently.

On Tue, 30 May 2023, 09:53 Reginald-Halifrax, @.***> wrote:

I can confirm this is true. The mod currently errors when attempting to integrate Create. For what little it's worth here is a latest.log https://github.com/TagnumElite/ProjectE-Integration/files/11597432/latest.log in a hyper-limited modpack containing the error.

— Reply to this email directly, view it on GitHub https://github.com/TagnumElite/ProjectE-Integration/issues/79#issuecomment-1567943237, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABRSLOJYXK4SOJLZUMPDD4DXIWRRBANCNFSM6AAAAAAYPJ2NLY . You are receiving this because you are subscribed to this thread.Message ID: @.***>

Reginald-Halifrax commented 1 year ago

Is there anything we (or I guess I) can do to potentially help?

ajsnarr98 commented 1 year ago

I don't know how much you have looked into this.. but I think the create mod in that update still has the same or similar classes for processing, but the package location has changed

ajsnarr98 commented 1 year ago

Pull Request: https://github.com/TagnumElite/ProjectE-Integration/pull/88

I just created a pull request (https://github.com/TagnumElite/ProjectE-Integration/pull/88) that fixes this bug. I tested it on a pack with create 0.5.1b, ProjectE-1.18.2-PE1.0.1, and some other mods also and am getting EMC values again. Also EMC values are correct based on shortcuts through create mod bulk haunting.

Would any of the maintainers here be able to take a look?

TheAnachronism commented 1 year ago

I hope this can be fixed @TagnumElite any news on your side? We have the same problem, although we're not sure if it's only because of create, that this issue appears.

TagnumElite commented 1 year ago

I will be fixing this in the next few days. Finally got a working PC.

tommy61157 commented 8 months ago

Did this ever get fixed?

tommy61157 commented 8 months ago

Can confirm that this does not seem to have been fixed