feat: add server logout handler

Tahul / nuxt-edgedb

💽 Nuxt 3 integration for EdgeDB

70 stars 7 forks source link

feat: add server logout handler #5

Closed juni0r closed 10 months ago

juni0r commented 10 months ago

Adds server action to properly terminate session by expiring the auth token cookie. Fixes #4.

Tahul commented 10 months ago

Good catch; I kinda rushed the auth part as I don't really need it for my current use-cases.

Would love having a review from you on that side.

Also, I guess we could go 1 step further and also include exports to simplify communication with OAuth providers APIs.

Currently, we don't preserve anything from these providers, like the email of a user from GitHub or Google.

WDYT?

juni0r commented 10 months ago

Hey, thanks for merging. I haven't looked at the OAuth stuff at all by now, so I can't give a qualified opinion. I'm totally new to EdgeDB and haven't used it before. As I'm growing more familiar with it over the coming weeks, I will come back with more input and the occasional PR. I think you did a great job with the module so far and I'm looking forward to helping shape it!