search

Taiko2k / Avvie

A GTK app for quick image cropping :flower_playing_cards:
GNU General Public License v3.0
159 stars 19 forks source link

[Bug] Dark theme not working #13

Closed demeralde closed 2 years ago

demeralde commented 4 years ago

I have the dark theme set on my machine. It works with all apps but this one:

![Dark theme not working](https://user-images.githubusercontent.com/9282837/94352339-d1d48580-00a2-11eb-8b78-44e6a1937c5e.pn g)

I checked the settings and there doesn't seem to be a way to switch to a dark theme. The screenshot in the README is dark, so I'm not sure why this doesn't work.

Environment

Taiko2k commented 4 years ago

Its actually intended to be dark theme only. I don't think there's any issue with Avvie.

I believe this is an issue related to Flatpak when you use a custom theme that isn't also packaged for Flatpak, it defaults to Adwaita light. Could be considered a bug, though you can also solve the issue by getting your theme packaged for Flatpak (on Flathub).

demeralde commented 4 years ago

@Taiko2k just looked into that and struggling to do so.

I installed org.gtk.Gtk3theme.Adwaita-dark. But I don't know how to configure flatpak to use it. I've tried looking online with no luck. Do you have any ideas?

Taiko2k commented 4 years ago

If you have your custom system theme applied, then running flatpak update should automatically install it if available. Though Adwaita-dark should be built in by default. Are you running a custom theme, or the default Adwaita?

demeralde commented 4 years ago

@Taiko2k hmm, flatpak update didn't work.

I'm not using a custom theme. I'm using Ubuntu's default dark theme in the system settings. Although I'm also using Regolith, which is basically a custom i3 setup for Ubuntu (maybe this has some theming config that's messing with it)?

Taiko2k commented 4 years ago

Just did a test with latest vanilla Ubuntu 20.04 and seems to be working as expected.

Screenshot from 2020-09-27 18-16-40-cropped

So likely something to do with your configuration.

demeralde commented 4 years ago

@Taiko2k hmm strange. Maybe a reboot or something will fix it. I'll figure it out eventually

SuperZoops commented 3 years ago

Try the permissions command, that fixed themeing issues for me.

demeralde commented 3 years ago

@SuperZoops what's the name of the permission you used with permission-set?

alice-mkh commented 2 years ago

I believe this is an issue related to Flatpak when you use a custom theme that isn't also packaged for Flatpak, it defaults to Adwaita light. Could be considered a bug, though you can also solve the issue by getting your theme packaged for Flatpak (on Flathub).

It's GTK doing it. It shouldn't be an issue with libadwaita or libhandy.

Taiko2k commented 2 years ago

This probably isn't reverent any more with the switch to Adwaita I assume. Ill close this.