Feature requests, Bugs and Observations

Disonantemus commented 1 year ago

Feature Request:

Sorted in personal preference priority order:

More presets: 4:3 and 3:4 should be presets (no custom), I use it a lot for portraits (vertical and horizontal) and it's slow to change Custom for every image.
Keyboard shortcuts for quick change aspect ratio presets without mouse (maybe like: 1 2 3 4 5 6).
Show actual filename in UI.
Delete button & shortcut, to not remove pictures with another image viewer in a previous step.
Keyboard shortcuts in README.md (github).
Change selection size not from corners (similar to Gimp maybe?).
Help page or URL with shortcuts.
Webp support (lossless and lossy), i've using this a lot because size reduction and a lot webpages use it.

Bugs:

Selection rectangle grow beyond image limits when changing aspect ratios, maybe when is larger should shrink to allowed limits.
Problems with aspect ratios 16:10 16:9 21:9 and Custom:
- Weird snap steps when changing size.
- While changing corner, also change opposing corner with all corners (except right-bottom one). Also [Shift] drag is weird with this.
Right-bottom corner thumbnails should stay in bottom, right now only is like that, with 1:1 aspec ratio (square).
Size in top-left thumbnail corner should be thumbnail size, the cropped size is already in selection rectangle.
When using meson says:
```
WARNING: Running the setup command as `meson [options]` instead of `meson setup [options]` is ambiguous and deprecated.
```
Maybe change README.md to meson setup builddir --prefix=/usr/local to not get the warning in 1st place.
After installing with meson+ninja, when trying to remove Avvie folder says (for each language): rm: cannot remove '/home/kuro/GIT/Avvie/builddir/po/nl/LC_MESSAGES/avvie.mo': Permission denied I know that I can use: sudo rm -rf Avvie/, but maybe avvie.mo shouldn't has root permission?

Questions and observations:

It's possible to sharpen jpg without recompression?
There are some size restrictions with jpg lossless crop? (iMCU [8 or 16] boundary) maybe when it's JPG and lossless mode on, should snap to 8 or 16 pixels?
Why says EXIF in top-right corner of the biggest thumbnail?
In README.md it wasn't clear to me that Downscale and bellow options are resize and aren't JPG lossless, maybe it's me, English it's not my native language.

PD: I'm testing this once a week when doing Second Life Photography for a DJ friend.

Taiko2k commented 1 year ago

More presets: 4:3 and 3:4 should be presets (no custom), I use it a lot for portraits (vertical and horizontal) and it's slow to change Custom for every image.

Redesigning the selections here to something more like a drop down menu is actually next on my todo list. Adding those as presets sounds like a good idea

[ ] todo

Keyboard shortcuts for quick change aspect ratio presets without mouse (maybe like: 1 2 3 4 5 6).

Not sure thats common enough to warrant a shortcut, or at least probably not the number keys alone.

Show actual filename in UI.

[ ] todo

Delete button & shortcut

[ ] todo

Keyboard shortcuts in README.md (github).

[ ] todo

Change selection size not from corners (similar to Gimp maybe?).

Maybe todo, its just a bit of a mess this part of the codebase currently

Help page or URL with shortcuts.

For now probably the README.md is good enough for this

Webp support (lossless and lossy), i've using this a lot because size reduction and a lot webpages use it.

[ ] todo

Im also interested in adding JPEG-XL support as well

Selection rectangle grow beyond image limits when changing aspect ratios

[ ] tofix

Problems with aspect ratios 16:10 16:9 21:9 and Custom: - Weird snap steps when changing size.

Its trying so snap to sizes matching those ratios, are you saying they're incorrect?

Size in top-left thumbnail corner should be thumbnail size, the cropped size is already in selection rectangle.

The final size may be different due to downscaling

Right-bottom corner thumbnails should stay in bottom, right now only is like that, with 1:1 aspec ratio (square).

[ ] tofix

When using meson says:

[ ] tofix

After installing with meson+ninja, when trying to remove Avvie folder says (for each language):

[ ] tofix

It's possible to sharpen jpg without recompression?

No

There are some size restrictions with jpg lossless crop? (iMCU [8 or 16] boundary) maybe when it's JPG and lossless mode on, should snap to 8 or 16 pixels?

Sounds like an idea, but not high priority since the thumbnail already shows the affected output.

[ ] todo

Why says EXIF in top-right corner of the biggest thumbnail?

This is to indicate that the output will carry over with the EXIF data. You can change the setting to ignore keeping the EXIF.

The reason its there is originally there was only one thumbnail and all the information related to exporting was in the bottom corner with it. Then later multiple thumbnails were added, so its just sort of a carry over from the historic design path.

In README.md it wasn't clear to me that Downscale and bellow options are resize and aren't JPG lossless, maybe it's me, English it's not my native language.

Yeah I should have made that more clear in the documentation. It is technically possible to do a lossless scale on a JPEG I believe but not many viewer are compatible with these special JPEGS. Avvie doesn't currently support this.

[ ] todo - add lossless behavior notes to readme

Disonantemus commented 1 year ago

Problems with aspect ratios 16:10 16:9 21:9 and Custom: - Weird snap steps when changing size.

Its trying so snap to sizes matching those ratios, are you saying they're incorrect?

Sample

As you can see, using 16:9, jump/snap from: 1600x900 > 1584x891 > 1568x882 > 1552x873 > 1536x864
Than means, the jump/snap are: 16x9
Maybe you are allowing only resolutions that are perfect 16:9 integers, I understand why, but when you are searching for a specific height, sometimes it's not available.
I think this is not a bug, but maybe it's possible to make the crop by rounded numbers to get more possible resolutions in between, and grow/shrink by 1 pixels steps, like:
1422x800 >> 1422/800 = 1.7775 =~ 1.777 = 16:9
That's very close.

[Feature]

Maybe greyout the things that are not lossless when JPEG Lossless mode It's active.

Disonantemus commented 1 year ago

[Bug Report]

Exporting with JPEG Lossless mode, resulting image has different resolution than avvie shows.

Checked with:

exiv2
mediainfo
nsxiv
ffprobe

Steps to reproduce:

Open a jpg image
Don't change default 924x924 crop size
Export
Resulting image has 924x924 size as expected

But, if you move selection by dragging in the center, that changes:

Just move a little from the corner (top-left): 925x924
bottom-left: 924x928
bottom-right: 928x928
top-right: 928x924

And avvie still shows 924x924.

I did some experiment with jpegtran and it's not very consistent with the sizes that I asked (using same image):

I tried getting a 928x928 image (because iMCU, both are x16 integers): jpegtran -copy none -strict -optimize -perfect -trim -crop 928x928+510+1500 -outfile out.jpg in.jpg And I get 934x932.

With some trial and error, I did get 928x928 output, but using 922x924, it's odd (maybe because roundings that needs to be done): jpegtran -copy none -strict -optimize -perfect -trim -crop 922x924+510+1500 -outfile out.jpg in.jpg

Taiko2k / Avvie