Taiko2k / Tauon

The music player of today! :city_sunrise:
https://tauonmusicbox.rocks
GNU General Public License v3.0
1.64k stars 64 forks source link

Re-design shuffle / repeat icons #1037

Open Taiko2k opened 9 months ago

Taiko2k commented 9 months ago

The current repeat and shuffle buttons while visually unique may be un-intuitive for new users. A new design may be better. Feel free to give your feedback and or submit a design proposal.

Considerations:

Solarunit commented 9 months ago

I like the current unique buttons, I don't have a problem with them, I mostly use Repeat track.

skylineone044 commented 8 months ago

Design proposal: tauon_repeat_shuffle_v1

This includes all 4 variants, and the emblems on the left can be excluded form each one if need be.

Taiko2k commented 8 months ago

Wow that's really cool, if you can put each of those as an SVG I can try it out. Keep the icon on the left in seperate svgs, and I might only use the album varients, not the track ones.

skylineone044 commented 8 months ago

Sure, here they are: tauon_shuffle_repeat_icon_components.zip

Taiko2k commented 8 months ago

Ok Ive committed this change now. Thanks for contribution!

Ive taken some creative liberty to what I think might be more visually readable.

Screenshot from 2023-11-03 14-00-04

Screenshot from 2023-11-03 14-02-56

I'm open to any feedback.

Solarunit commented 8 months ago

How they look in disabled state? I think it looks okay, but imo shuffle icon on top is too wide, I like the one at the bottom. I think the arrow shape-part of the "left" (repeat) and "right" (shuffle) icons should be the same width..

Taiko2k commented 8 months ago

When disabled they look the same as the top set.

One benefit of it being wide is it maintains the same general shape between modes. And it fills the wide hitbox area.

skylineone044 commented 8 months ago

The 1 and the album are a bit above the arrow on the repeat icon, I think they should be centered: tauon_repeat_a tauon_repeat

Solarunit commented 8 months ago

The 1 and the album are a bit above the arrow on the repeat icon, I think they should be centered:

I agree

One benefit of it being wide is it maintains the same general shape between modes. And it fills the wide hitbox area.

I mean making it the same with as shorter one but with another shuffle state indicator, similar to the 1 or album circle


Other idea: make state indicator (like 1 and album) symmetrical, e.g. by moving album to the right of the shuffle arrow

StrangeSeasOfThought commented 7 months ago

The shuffle icon is so wiiiiiide. It shouldn't be (that much) wider than the repeat icon imo, or any other icon. It's like 1/3 of the volume bar, looks really strange that wide.

Solarunit commented 7 months ago

I agree, it should be the same width as the repeat icon in inactive state