Taiko2k / Tauon

The music player of today! :city_sunrise:
https://tauonmusicbox.rocks
GNU General Public License v3.0
1.64k stars 64 forks source link

Multi-disk albums are grouped incorrectly #1063

Open andreyorst opened 7 months ago

andreyorst commented 7 months ago

I have a three-disk album that is stored like this:

Album Name
├── CD1
│   ├── cd_rip.flac
│   └── cd_rip.cue
├── CD2
│   ├── cd_rip.flac
│   └── cd_rip.cue
└── CD3
    ├── cd_rip.flac
    └── cd_rip.cue

File names inside the directories are identical, and all of the album metadata is also identical, except for the disk field, which is set correctly for each file.

After importing the release into the Tauon I get this kind of view:

________________________________________Album Name
track1 from cd1
________________________________________Album Name
track1 from cd2
________________________________________Album Name
track1 from cd3
________________________________________Album Name
track2 from cd1
________________________________________Album Name
track2 from cd2
________________________________________Album Name
track2 from cd3
________________________________________Album Name
track3 from cd1
________________________________________Album Name
track3 from cd2
________________________________________Album Name
track3 from cd3
________________________________________Album Name
track4 from cd1
________________________________________Album Name
track4 from cd2
________________________________________Album Name
track4 from cd3
...

Instead of the expected:

________________________________________Album Name
track1 from cd1
track2 from cd1
track3 from cd1
track4 from cd1
...
________________________________________Album Name
track1 from cd2
track2 from cd2
track3 from cd2
track4 from cd2
...
________________________________________Album Name
track1 from cd3
track2 from cd3
track3 from cd3
track4 from cd3
...

Other music players don't have issues with such releases in my library, so it shouldn't be a problem with the metadata. Perhaps Tauon doesn't use the Disk metadata for grouping.


Tauon Music Box v7.7.0 from Flathub OS: Fedora Silverblue 39

Taiko2k commented 7 months ago

This is supposed to work, but is an ongoing issue of fixing edge cases. Its difficult for me to work on this without a test case, so it would be helpful if you could zip up one of those albums and send it to me and I can see whats going on. (Keep the folder structure and .cue files, but you can omit the audio files themselves.)

andreyorst commented 7 months ago

sure. This is hand-constructed, but I've managed to reproduce the issue with it: album.zip

image

Strawberry (Clementine fork) shows it like this:

image

but I know for sure that it relies on the metadata in the flac file itself, because if I change the CD there, the situation is the same as in Tauon:

image

Taiko2k commented 7 months ago

Currently Tauon doesn't scan tags from the actual audio file at all when using a CUE sheet, so yes that help explain it. Ive now committed a change so that it will now inherit tags from the audio file. I assume this should fix the issue.

andreyorst commented 5 months ago

I have updated to the 7.7.1 release and unfortunately the problem persists.