search

Taiko2k / Tauon

The music player of today! :city_sunrise:
https://tauonmusicbox.rocks
GNU General Public License v3.0
1.64k stars 64 forks source link

Status Notifier support for tray icon #1094

Open Solarunit opened 4 months ago

Solarunit commented 4 months ago

Some time ago Budgie DE adopted Status Notifier system for tray icons:

The System Tray applet was completely overhauled in Budgie 10.8. Historically we have used either na-tray or the XEmbed Protocol for the creation, management, and rendering of trays icons. In Budgie 10.8, our System Tray adopted the Status Notifier specification. This is a modern, vendor-agnostic solution that enables applications to communicate all relevant information for the rendering of their tray icon over DBus rather than being responsible for drawing tray icons and menus themselves, promoting the development of catered solutions by desktop environments and those developing panels for user experiences such as tiling window managers.

https://buddiesofbudgie.org/blog/state-of-the-budgie-2023

Because of this Tauon tray icon is no longer visible in the tray and :gear: icon is showed instead.

Could you add support of Status Notifier specification?

Taiko2k commented 4 months ago

I believe this should work as Tauon uses libappindicator which uses StatusNotifier. When you say a gear appears is that Tauons trap applet just without the icon? Or is it not appearing at all?

Solarunit commented 4 months ago

I can see icon, but it gear icon instead. Right click context menu works. Maybe it's because I have flatpak version?

Taiko2k commented 4 months ago

Afaik it works in Gnome and KDE, so it's something about Budgies implementation that is different.

Could be a bug in Tauon still, not sure.

Solarunit commented 4 months ago

I am not sure, I asked Budgie devs about it. And it's not only tauon, some other apps too.

Solarunit commented 4 months ago

maybe it can't find the tauon (flatpak) icon path location

Solarunit commented 4 months ago

Looks like Status Notifier doesn't allow a full path to the icon.

Taiko2k commented 4 months ago

That's probably it. Maybe gnome and KDE break that spec, cause I'm pretty sure this works on wayland for those.

So either sending the icon over dbus, or installing named icons? could be a solution here. Probably the former would be best.

Solarunit commented 4 months ago

sending the icon over dbus

does this mean sending the image data?

So either sending the icon over dbus, or installing named icons?

I was told either of those should probably work

Taiko2k commented 4 months ago

Yes I assume sending the pixel data is the propper way, what Tauon is doing with fullpaths to the user data folder is hack.

Solarunit commented 4 months ago

So could you add this "sending the icon over dbus" method?

Taiko2k commented 4 months ago

I'll add it to the Todo list, though anyone else is welcome to attempt a PR.

Solarunit commented 4 months ago

thanks

Solarunit commented 4 months ago

I created issue for Budgie, so maybe we will see some workaround on Budgie side..

Solarunit commented 4 months ago

I created issue for Budgie, so maybe we will see some workaround on Budgie side..

Update from Budgie side:

it'll still be broken in Flatpak because the full path to icon can't be resolved outside the sandbox